Re: [Qemu-devel] [PULL 00/11] s390x changes for 2.3

[Peter Maydell]

On 15 December 2014 at 11:35, Cornelia Huck <address@hidden> wrote:
> The following changes since commit 99c9c3cb24e566258a0a141178934f9cb5198842:
>
>   Merge remote-tracking branch 
> 'remotes/mjt/tags/pull-trivial-patches-2014-12-11' into staging (2014-12-11 
> 18:27:02 +0000)
>
> are available in the git repository at:
>
>
>   git://github.com/cohuck/qemu tags/s390x-20141215
>
> for you to fetch changes up to 5a9403c9bc36aaa3431083f152251e775c38b386:
>
>   s390x: update MAINTAINERS (2014-12-15 10:43:17 +0100)

Hi; I'm afraid this doesn't build for win32 or MacOSX
or 32-bit Linux:

32-bit Linux failures:
hw/s390x/s390-pci-bus.c: In function 's390_guest_io_table_walk':
hw/s390x/s390-pci-bus.c:283:11: error: cast from pointer to integer of
different size [-Werror=pointer-to-int-cast]
hw/s390x/s390-pci-bus.c:291:11: error: cast from pointer to integer of
different size [-Werror=pointer-to-int-cast]

Windows failures:

/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c: In
function ‘s390_guest_io_table_walk’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c:283:
warning: cast from pointer to integer of different size
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c:291:
warning: cast from pointer to integer of different size
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c: In
function ‘s390_translate_iommu’:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-bus.c:325:
warning: integer constant is too large for ‘long’ type

(those are just warnings but should be fixed anyway)

/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:15:23:
warning: sys/ioctl.h: No such file or directory
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:16:22:
warning: sys/mman.h: No such file or directory
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:18:23:
warning: linux/kvm.h: No such file or directory
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:19:24:
warning: asm/ptrace.h: No such file or directory
In file included from
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.c:32:
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:25:
error: expected specifier-qualifier-list before ‘__uint16_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:30:
error: expected specifier-qualifier-list before ‘__uint16_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:55:
error: expected specifier-qualifier-list before ‘__uint16_t’
/home/petmay01/linaro/qemu-for-merges/hw/s390x/s390-pci-inst.h:92:
error: expected specifier-qualifier-list before ‘__uint32_t’

...and a lot of other stuff that's probably just cascade from
trying to include a bunch of Linux headers.

MacOSX builds also fail for lack of linux/kvm.h.

Incidentally, trying to include kvm.h is really a
bad idea unless guarded by CONFIG_KVM, even on Linux. You'll
get whatever the system include directory's kvm.h has, which
might be older than the one we ship in the QEMU tree and is
quite likely for a different architecture.

thanks
-- PMM