qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 04/15] target-arm: Add vexpress machine secur


From: Greg Bellows
Subject: Re: [Qemu-devel] [PATCH v3 04/15] target-arm: Add vexpress machine secure property
Date: Mon, 15 Dec 2014 14:21:25 -0600


On 15 December 2014 at 13:43, Peter Maydell <address@hidden> wrote:
On 15 December 2014 at 18:51, Greg Bellows <address@hidden> wrote:
> Add "secure" Vexpress machine specific property to allow override of the
> default secure state configuration.  By default, when using the QEMU
> -kernel command line argument, Vexpress machines boot into NS/SVC.  When using
> the QEMU -bios command line argument, Vexpress machines boot into S/SVC.
>
> The secure state can be changed from the default specifying the secure
> state as a machine property.  For example, the below command line would enable

disable!

> secure state on a -linux boot:
>
>     aarch64-softmmu/qemu-system-aarch64
>         -machine type=vexpress-a15,secure=off
>         -kernel ...
>
> Signed-off-by: Greg Bellows <address@hidden>
> Reviewed-by: Peter Maydell <address@hidden>

> +    /* EL3 is enabled by default on vexpress */
> +    vms->secure = true;
> +    object_property_add_bool(obj, "secure", vexpress_get_secure,
> +                             vexpress_set_secure, NULL);
> +    object_property_set_description(obj, "secure",
> +                             "Set on/off to enable/disable secure state",
> +                             NULL);

I think we decided on IRC that
"Set on/off to enable/disable the ARM Security Extensions (TrustZone)"

was slightly more explanatory for the user?

bah... yes we did.  I made the code change, but failed to update the patch.
 

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]