Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows

[Yan Vugenfirer]

Hi,

My suggestion is to handle the case when the newer OS will be installed in the guest as well.

Please look at version helper API - http://msdn.microsoft.com/en-us/library/windows/desktop/dn424972(v=vs.85).aspx 

and keep in mind that the usual GetVersion and GetVersionEx (that returned major, minor versions and build number) will be deprecated or changed after Windows 8.1.

Thanks,

Yan.

On Dec 16, 2014, at 9:30 AM, zhanghailiang <address@hidden> wrote:

Hi,

This patch series add a new guest command 'guest-get-os-version'.
It is now only available for windows guest.

It will return guest's OS version name and type, like bellow:
'{"return":{"name":"Microsoft Windows Server 2012 R2","type":64}}'

Sometimes we need to know guest's OS version info.
(Actually, we need this info when we update guest's applications and drivers
in our project.)

This patch is only RFC, it is another try to add more commands for qemu-ga.
Though qemu-ga has supported some commands now, but it is not enough and some
of them only support for linux ...

I would like to enrich it, if someone think it is acceptable.

So, any comments will be welcome! Thanks ;)

zhanghailiang (2):
 qga: Introduce guest-get-os-version command with stubs
 qga: implement qmp_guest_get_os_version for windows

qga/commands-posix.c |   7 +++
qga/commands-win32.c | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++
qga/qapi-schema.json |  26 +++++++++++
3 files changed, 158 insertions(+)

--
1.7.12.4