[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0 |
Date: |
Tue, 16 Dec 2014 15:10:04 +0200 |
On Thu, Dec 11, 2014 at 02:25:19PM +0100, Cornelia Huck wrote:
> virtio-net (non-vhost) now should have everything in place to support
> virtio 1.0: let's enable the feature bit for it.
>
> Note that VIRTIO_F_VERSION_1 is technically a transport feature; once
> every device is ready for virtio 1.0, we can move setting this
> feature bit out of the individual devices.
>
> Signed-off-by: Cornelia Huck <address@hidden>
So to use this with e.g. tun, you need to make tun device LE.
I posted a kernel patch address@hidden
with TUNSETVNETLE/TUNGETVNETLE ioctls to support it.
But you still need to call them in qemu, and disable virtio-1.0
if not there.
> ---
> hw/net/virtio-net.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index 7ee2bd6..b5dd356 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -473,6 +473,7 @@ static uint64_t virtio_net_get_features(VirtIODevice
> *vdev, uint64_t features)
> }
>
> if (!get_vhost_net(nc->peer)) {
> + virtio_add_feature(&features, VIRTIO_F_VERSION_1);
> return features;
> }
> return vhost_net_get_features(get_vhost_net(nc->peer), features);
> --
> 1.7.9.5
- [Qemu-devel] [PATCH RFC v6 07/20] virtio: allow virtio-1 queue layout, (continued)
- [Qemu-devel] [PATCH RFC v6 07/20] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 13/20] virtio: allow to fail setting status, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 14/20] s390x/virtio-ccw: enable virtio 1.0, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 11/20] s390x/virtio-ccw: support virtio-1 set_vq format, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 15/20] virtio-net: no writeable mac for virtio-1, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 18/20] virtio: support revision-specific features, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 20/20] vhost: 64 bit features, Cornelia Huck, 2014/12/11
- [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0, Cornelia Huck, 2014/12/11
- Re: [Qemu-devel] [PATCH RFC v6 17/20] virtio-net: enable virtio 1.0,
Michael S. Tsirkin <=
- [Qemu-devel] [PATCH RFC v6 19/20] virtio-blk: revision specific feature bits, Cornelia Huck, 2014/12/11