Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows

[Eric Blake]

On 12/16/2014 12:30 AM, zhanghailiang wrote:
> Hi,
> 
> This patch series add a new guest command 'guest-get-os-version'.
> It is now only available for windows guest.

Why not also supply it for Linux guests?  uname() is your friend; it
should be fairly easy to wire up.

> 
> It will return guest's OS version name and type, like bellow:
> '{"return":{"name":"Microsoft Windows Server 2012 R2","type":64}}'
> 
> Sometimes we need to know guest's OS version info.
> (Actually, we need this info when we update guest's applications and drivers 
> in our project.)

Have you looked into libguestfs' ability to get this information from an
(offline) guest image?  I'm not rejecting this command, but trying to
make sure that it is not duplicating something that can already be done.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature