Re: [Qemu-devel] [RFC PATCH 0/2] qga: add guest-get-os-version for windows

[zhanghailiang]

On 2014/12/17 0:25, Eric Blake wrote:
> On 12/16/2014 12:30 AM, zhanghailiang wrote:
> > Hi,
> >
> > This patch series add a new guest command 'guest-get-os-version'.
> > It is now only available for windows guest.
>
> Why not also supply it for Linux guests?  uname() is your friend; it
> should be fairly easy to wire up.

Er, this patch is RFC, i don't know if this idea (support get-os-version 
command) is acceptable,
I will add it in next formal version if it is acceptable. ;)

> > It will return guest's OS version name and type, like bellow:
> > '{"return":{"name":"Microsoft Windows Server 2012 R2","type":64}}'
> >
> > Sometimes we need to know guest's OS version info.
> > (Actually, we need this info when we update guest's applications and drivers
> > in our project.)
>
> Have you looked into libguestfs' ability to get this information from an
> (offline) guest image?  I'm not rejecting this command, but trying to
> make sure that it is not duplicating something that can already be done.

I have look into libgustfs codes, and yes, it supports get this info from 
offline guest image,
but unfortunately we don't use libguestfs in our project.
(I also make a simple test to get proudct name by using
"virt-inspector -d redhat-6.4  | virt-inspector --xpath '//product_name'",
it is a little  time consuming (about 12s)).

So, what's your suggestion?

Thanks,
zhanghailiang