Re: [Qemu-devel] [PATCH v3 0/3] qmp: Add "blockdev-backup"

[Markus Armbruster]

Fam Zheng <address@hidden> writes:

> v3: Address Eric's comments on documentation.
>     Squashed 3/4 into 2/4.
>
> v2: Address Markus' and Eric's comments:
>     Fix qapi schema documentation.
>     Fix versioning of transactions.
>     Improve test case code by dropping inelegnet bool.
>
> The existing drive-backup command accepts a target file path, but that
> interface provides little flexibility on the properties of target block 
> device,
> compared to what is possible with "blockdev-add", "drive_add" or "-drive".
>
> This is also a building block to allow image fleecing (creating a point in 
> time
> snapshot and export with nbd-server-add).
>
> (For symmetry, blockdev-mirror will be added in a separate series.)

Trivial typos/pastos in PATCH 1, and a question on GenericError.  If you
address these, you can add my R-by.