[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 00/14] block: Remove "growable", add blk_new_ope
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 00/14] block: Remove "growable", add blk_new_open() |
Date: |
Thu, 18 Dec 2014 16:16:43 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 11.12.2014 um 14:20 hat Max Reitz geschrieben:
> This series removes the "growable" field from the BlockDriverState
> object. Its use was to clamp guest requests against the limits of the
> BDS; however, this can now be done more easily by moving those checks
> into the BlockBackend functions.
>
> In a future series, "growable" may be reintroduced (maybe with a
> different name); it will then signify whether a BDS is able to grow (in
> contrast to the current "growable", which signifies whether it is
> allowed to). Maybe I will add it to the BlockDriver instead of the BDS,
> though.
>
> To be able to remove that field, qemu-io needs to be converted to
> BlockBackend, which is done by this series as well. While working on
> that I decided to convert blk_new_with_bs()+bdrv_open() to
> blk_new_open(). I was skeptical about that decision at first, but it
> seems good now that I was able to replace nearly every blk_new_with_bs()
> call by blk_new_open(). In a future series I may try to convert some
> remaining bdrv_open() calls to blk_new_open() as well.
>
> Finally, the question needs to be asked: If, after this series, every
> BDS is allowed to grow, are there any users which do not use BB, but
> should still be disallowed from reading/writing beyond a BDS's limits?
> The only users I could see were the block jobs. Some of them should
> indeed be converted to BB; but none of them takes a user-supplied offset
> or size, all work on the full BDS (or only on parts which have been
> modified, etc.). Therefore, it is by design impossible for them to
> exceed the BDS's limits, which makes making all BDS's growable safe.
>
>
> This series depends on "[PATCH v3 0/3] iotests: Fix test 039".
I'm afraid this series needs rebasing.
Kevin
- [Qemu-devel] [PATCH 07/14] qemu-img: Use BlockBackend as far as possible, (continued)
- [Qemu-devel] [PATCH 07/14] qemu-img: Use BlockBackend as far as possible, Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 10/14] qemu-io: Remove "growable" option, Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 08/14] qemu-nbd: Use blk_new_open() in main(), Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 11/14] qemu-io: Use BlockBackend, Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 13/14] block: Remove "growable" from BDS, Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 14/14] block: Keep bdrv_check*_request()'s return value, Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 09/14] qemu-io: Use blk_new_open() in openfile(), Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 03/14] blockdev: Use blk_new_open() in blockdev_init(), Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 01/14] block: Lift some BDS functions to the BlockBackend, Max Reitz, 2014/12/11
- [Qemu-devel] [PATCH 12/14] block: Clamp BlockBackend requests, Max Reitz, 2014/12/11
- Re: [Qemu-devel] [PATCH 00/14] block: Remove "growable", add blk_new_open(),
Kevin Wolf <=