Re: [Qemu-devel] [PATCH 5/8] target-i386: Set APIC ID using cpu_index on CONFIG_USER

[Eduardo Habkost]

On Fri, Dec 19, 2014 at 12:22:30PM +0100, Paolo Bonzini wrote:
> On 19/12/2014 03:41, Eduardo Habkost wrote:
> > +    object_property_set_int(OBJECT(cpu), CPU(cpu)->cpu_index, "apic-id",
> > +                            &error);
> > +    if (error) {
> > +        goto out;
> > +    }
> > +
> 
> Should this use &error_abort?

I normally use &error_abort only if there is no way to indicate errors
to the caller at all. In this case, we print the error message and
return NULL.

However, I was assuming that all callers of cpu_init() check for NULL
properly, and cpu_copy() at linux-user/main.c doesn't. As I don't want
to touch linux-user code or change the cpu_init() signature, I will use
&error_abort in the next version.

-- 
Eduardo