Re: [Qemu-devel] [PATCHv2 8/8] pseries: Export RTC time via QOM

[David Gibson]

On Tue, Dec 23, 2014 at 01:26:58AM +0100, Alexander Graf wrote:
> 
> 
> On 23.12.14 01:17, David Gibson wrote:
> > On x86, the guest's RTC can be read with QMP, either from the RTC device's
> > "date" property or via the "rtc-time" property on the machine (which is an
> > alias to the former).  This is set up in the mc146818rtc driver, and
> > doesn't work on other targets.
> > 
> > This patch adds a similar "date" property to the pseries machine's RTAS RTC
> > and adds a compatible alias to the machine.
> > 
> > Signed-off-by: David Gibson <address@hidden>
> 
> Very nice, can we somehow get rid of an exported spapr_rtc_read() with
> this as well?

Uhhh.. we could, but I really don't like the idea.

It seems perverse to encode the current time into JSON, just so we can
decode it into a struct tm again in the events code.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson

pgp5TCV9q2A2o.pgp
Description: PGP signature