Re: [Qemu-devel] [PATCH v3 6/7] tests/Makefile: Add check-block to make check on Linux

[Peter Maydell]

On 31 December 2014 at 04:30, Fam Zheng <address@hidden> wrote:
> "make check-block" does nothing on other platforms, but still takes some
> time to enumerate all the tests. So let's only add it for Linux for now.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
>  tests/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index e4ddb6a..0968121 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -467,6 +467,9 @@ check-qtest: $(patsubst %,check-qtest-%, $(QTEST_TARGETS))
>  check-unit: $(patsubst %,check-%, $(check-unit-y))
>  check-block: $(patsubst %,check-%, $(check-block-y))
>  check: check-qapi-schema check-unit check-qtest
> +ifeq ($(shell uname -s),"Linux")

You can just use
ifeq ($(CONFIG_LINUX), y)
here, since configure has already identified the host.

thanks
-- PMM