Re: [Qemu-devel] [PATCH 00/10] block/dmg: (compatibility) fixes and bzip2 support

[John Snow]

On 01/02/2015 01:46 PM, Peter Wu wrote:
> FYI, I plan to make some more changes:
>
> - do not require offset ≠ 0 for resource fork and XML offsets. Technically it 
> is allowed, do you agree on this change?

If you have seen this in the wild, I definitely agree. If you haven't, I 
am not against the change, but there's likely no hurry to include it in 
this series if the changes are not simple.

> - improve offset checking 
> https://git.lekensteyn.nl/peter/qemu/commit/?h=block-dmg-2.3&id=41fd83773361923f668f54796ff563660b77e96c
>  (squash with the existing length checking patch)
>
> - (not part of this series, but for future consideration) read errors currently 
> return 1 (EPERM). EIO or EINVAL would probably a better choice depending on the 
> error type.
>
> Other than that, the patches should be ready for review. Thank you in advance.
>
> Kind regards,
> Peter
> https://lekensteyn.nl
> (pardon my brevity, top-posting and formatting, sent from my phone)
>
>
> On January 2, 2015 5:31:33 PM CET, John Snow <address@hidden> wrote:
> > On 01/02/2015 09:14 AM, Stefan Hajnoczi wrote:
> > > On Sat, Dec 27, 2014 at 04:01:34PM +0100, Peter Wu wrote:
> > > > These series improve QEMU support for DMG image files:
> > >
> > > Hi,
> > > Thanks for this patch series.  Kevin and I consider patches for
> > merging
> > > after they have a Reviewed-by: from at least 1 other QEMU
> > contributor.
> > > I have CCed John Snow.
> > >
> > > John: If you are busy, please CC someone else or let us know so this
> > > series can get reviewed.
> > >
> > > Stefan
> >
> > Just recomposing myself post-vacation, I will start looking this over
> > today.
> >
> > --John