qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 04/10] block/dmg: process a buffer instead of re


From: John Snow
Subject: Re: [Qemu-devel] [PATCH 04/10] block/dmg: process a buffer instead of reading ints
Date: Fri, 02 Jan 2015 19:01:45 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0



On 12/27/2014 10:01 AM, Peter Wu wrote:
As the decoded plist XML is not a pointer in the file,
dmg_read_mish_block must be able to process a buffer instead of a file
pointer. Since the full buffer must be processed, let's change the
return value again to just a success flag.

Signed-off-by: Peter Wu <address@hidden>
---
  block/dmg.c | 60 ++++++++++++++++++++++++++++++------------------------------
  1 file changed, 30 insertions(+), 30 deletions(-)

diff --git a/block/dmg.c b/block/dmg.c
index 7f49388..75e771a 100644
--- a/block/dmg.c
+++ b/block/dmg.c

[snip]

I see; because your plist XML implementation has to decode base64 data, this function needs to be able to operate on a buffer instead of taking an offset into the file, because we may need to do some processing on the mish data first.

Reviewed-by: John Snow <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]