[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Bug 1407454] Re: assertion failed when using "-usb" op
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Bug 1407454] Re: assertion failed when using "-usb" option |
Date: |
Mon, 5 Jan 2015 10:45:24 +0000 |
On Mon, Jan 5, 2015 at 5:48 AM, Tiejun Chen <address@hidden> wrote:
> Could you test this?
>
> Signed-off-by: Tiejun Chen <address@hidden>
> ---
> util/qemu-option.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/util/qemu-option.c b/util/qemu-option.c
> index a708241..7cb3601 100644
> --- a/util/qemu-option.c
> +++ b/util/qemu-option.c
> @@ -377,7 +377,7 @@ static bool qemu_opt_get_bool_helper(QemuOpts *opts,
> const char *name,
> }
>
> opt = qemu_opt_find(opts, name);
> - if (opt == NULL) {
> + if ((opt == NULL) || !opt->desc) {
> const QemuOptDesc *desc = find_desc_by_name(opts->list->desc, name);
> if (desc && desc->def_value_str) {
> parse_option_bool(name, desc->def_value_str, &ret, &error_abort);
This doesn't work because it discards the usb=on|off value that was
set on the command-line.
I will send a fix.
Stefan
[Prev in Thread] |
Current Thread |
[Next in Thread] |