Re: [Qemu-devel] [PATCH] tcg-aarch64: handle additional PXN case

[Peter Maydell]

On 5 January 2015 at 12:52, Andrew Jones <address@hidden> wrote:
> On Mon, Jan 05, 2015 at 11:54:17AM +0000, Peter Maydell wrote:
>> This condition is becoming pretty badly overweight. I think that
>> rather than just add another clause to it (especially one which
>> needs an embedded /* comment */ !) we should split it up somehow.
>> (Consider also that as per the comment we're going to need to
>> distinguish UXN from XN shortly for EL2/EL3.)
>
> I can take a stab at cleaning this up. The thought had crossed my
> mind as well.

That would be cool, thanks.

>> We don't implement the SCTLR.UWXN/WXN bits either -- don't know
>> if you care about those.
>
> I care in the sense that I'd like tcg-aarch64 to be as accurate as
> possible, but I haven't bumped into a need for WXN support yet,
> as I have with this PXN condition. I can throw support into the new
> 'prot = check_xn(...)' function that we'll create for the cleanup.

Mmm; I don't insist on you adding support, but it would
be nice since I think that's the only other missing bit
of XN checking logic.

-- PMM