Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

[Peter Maydell]

On 24 November 2014 at 11:47, Claudio Fontana
<address@hidden> wrote:
> On 21.11.2014 19:07, Alvise Rigo wrote:
>> Keep a global list with all the functions that need to modify the device
>> tree.  Using qemu_add_machine_init_done_notifier we register a notifier
>> that executes all the functions on the list and loads the kernel.
>>
>> Signed-off-by: Alvise Rigo <address@hidden>
>
> Peter, could you weigh in about whether this is a good idea or not?

Sorry, I think I must have missed this series first time around.
I'm not convinced -- I don't see any reason why we should treat
the PCI host controller differently from other devices in the
virt board: just generate an appropriate dtb fragment in virt.c.

thanks
-- PMM