Re: [Qemu-devel] [RFC v2 1/4] hw/arm/virt: Allow multiple agents to modify dt

[alvise rigo]

Hi,

On Mon, Jan 5, 2015 at 4:36 PM, Peter Maydell <address@hidden> wrote:
> On 24 November 2014 at 11:47, Claudio Fontana
> <address@hidden> wrote:
>> On 21.11.2014 19:07, Alvise Rigo wrote:
>>> Keep a global list with all the functions that need to modify the device
>>> tree.  Using qemu_add_machine_init_done_notifier we register a notifier
>>> that executes all the functions on the list and loads the kernel.
>>>
>>> Signed-off-by: Alvise Rigo <address@hidden>
>>
>> Peter, could you weigh in about whether this is a good idea or not?
>
> Sorry, I think I must have missed this series first time around.
> I'm not convinced -- I don't see any reason why we should treat
> the PCI host controller differently from other devices in the

The reason for this is that the PCI host controller needs to generate
its device node after all the PCI devices have been added to the bus
(also those specified with the -device option).
This is required by the interrupt-map node property, that specifies
for each PCI device an interrupt map entry. Since we have one device
requiring this 'postponed' node generation, this patch allows also
other devices to do the same.
Recently I was thinking to another approach, which is to have multiple
dtb modifiers called by arm_boot_info.modify_dtb(). Is this
reasonable?

> virt board: just generate an appropriate dtb fragment in virt.c.

Of course, the method that generates the device node fragment can be
moved to virt.c, but the requirement of postponing its call after the
machine has been created still applies.

Thank you for your feedback,
alvise

>
> thanks
> -- PMM