[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH] exec.c: Drop TARGET_HAS_ICE define and checks |
|
Date: |
Mon, 05 Jan 2015 11:52:50 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 01/05/2015 11:09 AM, Peter Maydell wrote:
> The TARGET_HAS_ICE #define is intended to indicate whether a target-*
> guest CPU implementation supports the breakpoint handling. However,
> all our guest CPUs have that support (the only two which do not
> define TARGET_HAS_ICE are unicore32 and openrisc, and in both those
> cases the bp support is present and the lack of the #define is just
> a bug). So remove the #define entirely: all new guest CPU support
> should include breakpoint handling as part of the basic implementation.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
r~