[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding fu
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-devel] [PATCH 02/10] block/dmg: extract mish block decoding functionality |
|
Date: |
Tue, 6 Jan 2015 13:42:41 +0000 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sat, Dec 27, 2014 at 04:01:36PM +0100, Peter Wu wrote:
> Extract the mish block decoder such that this can be used for other
> formats in the future. A new DmgHeaderState struct is introduced to
> share state while decoding.
>
> The code is kept unchanged as much as possible, a "fail" label is added
> for example where a simple return would probably do.
>
> Signed-off-by: Peter Wu <address@hidden>
> ---
> block/dmg.c | 216
> +++++++++++++++++++++++++++++++++++-------------------------
> 1 file changed, 125 insertions(+), 91 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
pgpDszZHW3ehF.pgp
Description: PGP signature