qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creat

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic
Date: Tue, 06 Jan 2015 21:45:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 

On 06/01/2015 14:29, Marcel Apfelbaum wrote:
> @@ -1484,9 +1484,10 @@ static void ppc_spapr_init(MachineState *machine)
>      /* Graphics */
>      if (spapr_vga_init(phb->bus)) {
>          spapr->has_graphics = true;
> +        machine->usb |= defaults_enabled();
>      }

Could the solution be to do this in instance_init?  Then you would have
patches 2, 4, 5, 6, 3 (patch 1 would not be needed anymore).

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]