Re: [Qemu-devel] [PATCH 4/4] arm: enable Bochs PCI VGA

[Alexander Graf]

On 06.01.15 22:28, Peter Maydell wrote:
> On 6 January 2015 at 21:08, Alexander Graf <address@hidden> wrote:
>> On 06.01.15 17:16, Peter Maydell wrote:
>>> On 6 January 2015 at 16:03, Alexander Graf <address@hidden> wrote:
>>>> +CONFIG_VGA_PCI=y
>>>
>>> Why isn't this just in pci.mak like all the other PCI devices?
>>
>> Honestly, I have no idea. Maybe Michael knows? But if everyone agrees it
>> should be there, I'd be happy to move it.
> 
> Well, currently the only configs which include pci.mak and don't
> also define CONFIG_VGA_PCI are arm, m68k, sh4 and sh4eb, and with
> your change arm would move into the other category. It seems more
> likely to me that it's just oversight that it's not included in
> pci.mak...
> 
> At any rate, given that both sh4 and m68k are pretty much orphan
> currently, I don't think anybody's going to notice or complain
> about the existence of another PCI device :-)

Ok, works for me. I've changed to patch to move the PCI VGA and VGA
options to pci.mak.

I've not moved CIRRUS or QXL yet though. When I tried, cirrus didn't
work - it probably needs access to the legacy VGA regions that don't get
mapped with the gpex phb. And for QXL I'd rather have someone put a
stamp on it saying that it at least has a remote chance of working ;).


Alex