Re: [Qemu-devel] [PATCH 0/3] Migration cancel with dead network

[Paolo Bonzini]

On 08/01/2015 12:11, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
> 
> If the remote host, or networking dies during a migration, the socket can be
> waiting for a long timeout, and migration_cancel can't complete the cancel
> for a long time (and you can't start a new one to somewhere else).
> (Where 'long' is the TCP timeout, that's ~15 mins)
> 
> This patch set uses the shutdown(2) syscall to unblock any write/sends that
> are in progress to let the migrate_cancel happen quickly.
> 
>   1/3: socket shutdown  - An updated patch from my postcopy world to
>                           add a shut_down method on QEMUFile - only
>                           for 'socket' (where the syscall is supported).
> 
>   2/3: Handle bi-directional communication for fd migration
>                         - A patch from Cristian Klein to use the socket
>                           QEMUFile for FDs that are passed in, if the FDs
>                           are sockets; this is needed so that libvirt
>                           migrations can take advantage of the other patches.
>                           Again this patch (and its naming) come from the
>                           postcopy world.
> 
>   3/3: migration_cancel: shutdown migration socket
>                         - A new patch that uses the shutdown in 
> migrate_fd_cancel
> 
> 
> Note this does not fix the timeout if you try to migrate to an already dead 
> host;
> the connect timeout is typically a much shorter 2 minutes anyway.

A more precise commit message for 2/3 would be nice, but the code is good.

Reviewed-by: Paolo Bonzini <address@hidden>