qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions


From: Claudio Fontana
Subject: Re: [Qemu-devel] [PATCH 08/12] pci: allow 0 address for PCI IO regions
Date: Fri, 9 Jan 2015 15:57:39 +0100

Hello,

resurrecting an old thread.. I incurred in the same issue being
discussed before,
where QEMU silently ignores PCI BAR address programming attempts where
the I/O space offset is 0 (zero).

I think that from a QEMU "user" standpoint, beside this particular issue,
which can be easily worked around just using a minimum offset,
it would be good if QEMU would be a bit verbose in producing a warning
about this.

I think that at least it would be worth a message if DEBUG_PCI is set.

This silent discarding of BAR programming attempts has been painful
while doing early enablement
even for other cases (like the requirement to set I/O space bit before
hand etc), which are legitimate,
but are still worthy of a diagnostic I think, at the very least if
doing pci enablement (which to me translates in having DEBUG_PCI set).

What do you guys think, would a patch be welcome trying to address that?
Would you make the diagnostic dependent on DEBUG_PCI?

Thanks,

Claudio



reply via email to

[Prev in Thread] Current Thread [Next in Thread]