[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/8] qemu: guest agent: implement guest-exec command for Linux |
|
Date: |
Fri, 09 Jan 2015 10:10:28 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 |
On 01/09/2015 10:06 AM, Michael Roth wrote:
> The other one worth considering is allowing cmdline to simply be a string,
> to parse it into arguments using g_shell_parse_argv(), which should also
> be cross-platform.
Please no. Passing an unparsed string and asking for platform-specific
rules to reparse it is dangerous, compared to requiring the user to pass
an array of literal arguments that need no further reparsing.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature