Re: [Qemu-devel] [RFC PATCH v7 13/21] replay: recording and replaying different timers

[Paolo Bonzini]

On 12/01/2015 13:01, Pavel Dovgalyuk wrote:
> +    if (replay_mode == REPLAY_MODE_RECORD) {
> +        qemu_get_timedate_no_warning(&tm, 0);
> +        replay_save_tm(&tm);
> +    } else if (replay_mode == REPLAY_MODE_PLAY) {
> +        replay_read_tm(&tm);
> +    } else {
> +        qemu_get_timedate_no_warning(&tm, 0);
> +    }
>  

Can this be encapsulated in a simple function replay_get_timedate?  I
think the fewest replay_mode checks you have outside replay/, the better.

Paolo