[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] cpu_ldst.h: Collapse laddr() and saddr() in
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] cpu_ldst.h: Collapse laddr() and saddr() into ldst_get_host_addr() |
|
Date: |
Tue, 13 Jan 2015 19:15:00 +0000 |
On 13 January 2015 at 18:32, Peter Maydell <address@hidden> wrote:
> The macros laddr() and saddr() are always defined to be identical
> to each other. Replace them with a single macro, and give it a
> longer name so it's easier to grep the codebase and confirm that
> it's only used in this one place: ldst_get_host_addr().
Hmm. Actually I think we should be able to drop the _raw() accessors
entirely -- they're kind of nonsensical on softmmu and four unnecessary
extra characters on linux-user. (The only place we use them in softmmu
is in monitor.c where it should be using the ld*_p functions instead.)
I'll put together a patchset...
-- PMM