Re: [Qemu-devel] [PATCH 9/9] balloon: Eliminate silly QERR_ macros

[Eric Blake]

On 01/13/2015 10:50 AM, Markus Armbruster wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
> They're used with error_set() and qerror_report(), and expand into the
> first *two* arguments.  This trickiness has become pointless.  Clean
> up.

I like your wording in 6/9 better ("Clean this one up"), as it is more
obvious that you are only fixing a subset and not eliminating all such
macros.

> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  balloon.c                 | 6 ++++--
>  include/qapi/qmp/qerror.h | 6 ------
>  2 files changed, 4 insertions(+), 8 deletions(-)
> 

For this patch, and for all others in the series where I did not
explicitly reply,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature