Re: [Qemu-devel] [PATCH] WIP: add GCoroutine support

[Kevin Wolf]

Am 09.01.2015 um 18:19 hat Marc-André Lureau geschrieben:
> Learn to use the GCoroutine library instead of qemu own coroutine
> implementation.
> 
> GCoroutine is hosted on github:
> https://github.com/elmarco/gcoroutine
> 
> This allows to share the same coroutine implementation between various
> projects (gtk-vnc and spice-gtk). It is related to the effort to push
> coroutine support in GLib. See also:
> https://bugzilla.gnome.org/show_bug.cgi?id=719362

Hm, I guess there might be uses for holding references after the
coroutine has exited if there are external references to the coroutine,
but is it useful not to drop one reference after the coroutine exits? I
guess in most cases, and in qemu always, the caller isn't aware that the
coroutine ended, so requiring an explicit call isn't as nice as it could
be.

Also, you modified the copyright lines. Would you mind restoring the
author names as in the original code, as their license requires? I see
that you also converted MIT licensed code into LGPL, without keeping the
original license text as required. For my code, I'm fine with the
conversion, but you should either have asked or left the original text
in place.

Kevin