Re: [Qemu-devel] [PATCH 07/15] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop

[Alex Bennée]

Peter Maydell <address@hidden> writes:

> In the m68k cpu_loop() use get_user_u16 to read the immediate for
> the simcall rahter than lduw, to bring it into line with how other
> archs do it and to remove another user of the ldl family of functions.
>
> Signed-off-by: Peter Maydell <address@hidden>

After getting lost tracing the many macro definitions from lduw ;-)

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  linux-user/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 67b0231..65b5a36 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -2972,7 +2972,7 @@ void cpu_loop(CPUM68KState *env)
>              {
>                  if (ts->sim_syscalls) {
>                      uint16_t nr;
> -                    nr = lduw(env->pc + 2);
> +                    get_user_u16(nr, env->pc + 2);
>                      env->pc += 4;
>                      do_m68k_simcall(env, nr);
>                  } else {

-- 
Alex Bennée