qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] spice-char: fix wrong assert condition


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] spice-char: fix wrong assert condition
Date: Sat, 17 Jan 2015 11:52:10 +0000

On 17 January 2015 at 06:48, Zhang Haoyu <address@hidden> wrote:
> G_IO_OUT|G_IO_HUP are passed from all of the callers
> of chr_add_watch hooker, the assert condition MUST be
> changed.

"All the callers do this currently" isn't a reason to
change an assert. Possible reasons to change it include:
 * "X is required because if we don't then things break because Y"
 * "it is meaningless (a programming error) to do X, because Y"

Can you give the reasoning for changing this assert?
Does it apply also to other add_watch hook functions?
Would the assert be better at a higher level in the callstack?

thanks
-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]