[Qemu-devel] [PATCH] qdev: The sequence of devices added to bus

[Ting Wang]

When add a qdev device to bus, bus_add_child will be called.
But in this function, the new device is inserted to the head 
of the list. That means the sequence will be reversed.

For example, if there are three virtio-scsi devices with
lun 0 to 2 in the same controller, in the Guest, device with
lun 0 is always named as sda, device with lun 1 is named as
sdc, and device with lun 2 is named as sdb. So the order is
different from the lun number.

Signed-off-by: Ting Wang <address@hidden>
---
 hw/core/qdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 901f289..7d830a6 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -89,7 +89,7 @@ static void bus_add_child(BusState *bus, DeviceState *child)
     kid->child = child;
     object_ref(OBJECT(kid->child));
 
-    QTAILQ_INSERT_HEAD(&bus->children, kid, sibling);
+    QTAILQ_INSERT_TAIL(&bus->children, kid, sibling);
 
     /* This transfers ownership of kid->child to the property.  */
     snprintf(name, sizeof(name), "child[%d]", kid->index);
-- 
1.8.5