Re: [Qemu-devel] [PATCH] Add trace messages to input.c.

[Don Koch]

On Mon, 19 Jan 2015 08:34:22 +0100
Gerd Hoffmann <address@hidden> wrote:

> On Fr, 2015-01-16 at 14:08 -0500, Don Koch wrote:
> > Signed-off-by: Don Koch <address@hidden>
> 
> > +    trace_do_mouse_set(mon, index);
> 
> First, I think we should have a better name for that one, maybe
> "input_mouse_set" ?

The trace name or the routine it's in? The trace name was obviously
taken from the name of the routine it is in.

> Second I'm wondering what the use case is.  The place is a bit strange
> (tracing management not guest behavior), also all the existing input
> trace points log the device index so you can already see how the events
> are routed ...

I believe this was used for debugging vmware mouse support we've been
working on.

Thanks,
-d

> cheers,
>   Gerd
> 
>