[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xff
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] tcg: Use macro instead of hard code number 0xffffffff for tcg_target_ulong using |
|
Date: |
Mon, 19 Jan 2015 15:58:30 +0000 |
On 19 January 2015 at 15:34, Chen Gang <address@hidden> wrote:
> For tcg_target_ulong (include TCGArg), it often uses lower 32-bit mask
> and higher 32-bit mask, so define the related macro for it, so can let
> code simpler, and avoid various coding styles for them.
>
> - For lower, some append 'u', some append 'U', and some no 'u' or 'U'.
>
> - For higher, some append 'ull', some use type cast.
>
> - For lower but may be used higher bits, append 'ull'.
Is this patch fixing any actual bugs? I think code-style-wise
I prefer what we have at the moment...
-- PMM