[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/5] target-arm: Add feature parsing to virt
From: |
Greg Bellows |
Subject: |
[Qemu-devel] [PATCH 2/5] target-arm: Add feature parsing to virt |
Date: |
Mon, 19 Jan 2015 16:30:18 -0600 |
Added machvirt parsing of feature keywords added to the -cpu command line
option. Parsing occurs during machine initialization.
Signed-off-by: Greg Bellows <address@hidden>
---
hw/arm/virt.c | 21 +++++++++++++++++++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 2353440..cd192ae 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -573,12 +573,19 @@ static void machvirt_init(MachineState *machine)
MemoryRegion *ram = g_new(MemoryRegion, 1);
const char *cpu_model = machine->cpu_model;
VirtBoardInfo *vbi;
+ char *cpuname, *features;
if (!cpu_model) {
cpu_model = "cortex-a15";
}
- vbi = find_machine_info(cpu_model);
+ /* Separate the actual CPU model name from any appended features */
+ cpuname = g_strdup(cpu_model);
+ cpuname = strtok(cpuname, ",");
+ /* Keep track of the features for later parsing */
+ features = strtok(NULL, ",");
+
+ vbi = find_machine_info(cpuname);
if (!vbi) {
error_report("mach-virt: CPU %s not supported", cpu_model);
@@ -595,8 +602,10 @@ static void machvirt_init(MachineState *machine)
create_fdt(vbi);
for (n = 0; n < smp_cpus; n++) {
- ObjectClass *oc = cpu_class_by_name(TYPE_ARM_CPU, cpu_model);
+ ObjectClass *oc = cpu_class_by_name(TYPE_ARM_CPU, cpuname);
+ CPUClass *cc = CPU_CLASS(oc);
Object *cpuobj;
+ Error *err = NULL;
if (!oc) {
fprintf(stderr, "Unable to find CPU definition\n");
@@ -604,6 +613,13 @@ static void machvirt_init(MachineState *machine)
}
cpuobj = object_new(object_class_get_name(oc));
+ /* Handle any CPU options specfied by the user */
+ cc->parse_features(CPU(cpuobj), features, &err);
+ if (err) {
+ error_report("%s", error_get_pretty(err));
+ exit(1);
+ }
+
if (!vms->secure) {
object_property_set_bool(cpuobj, false, "has_el3", NULL);
}
@@ -623,6 +639,7 @@ static void machvirt_init(MachineState *machine)
object_property_set_bool(cpuobj, true, "realized", NULL);
}
+ g_free(cpuname);
fdt_add_timer_nodes(vbi);
fdt_add_cpu_nodes(vbi);
fdt_add_psci_node(vbi);
--
1.8.3.2
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, (continued)
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Igor Mammedov, 2015/01/20
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Peter Maydell, 2015/01/20
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Igor Mammedov, 2015/01/20
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Peter Maydell, 2015/01/20
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Igor Mammedov, 2015/01/20
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Greg Bellows, 2015/01/20
- Re: [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing, Igor Mammedov, 2015/01/21
[Qemu-devel] [PATCH 2/5] target-arm: Add feature parsing to virt,
Greg Bellows <=
[Qemu-devel] [PATCH 3/5] target-arm: Add 32/64-bit register sync, Greg Bellows, 2015/01/19
[Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64, Greg Bellows, 2015/01/19
[Qemu-devel] [PATCH 5/5] target-arm: Adjust kernel load address for Image, Greg Bellows, 2015/01/19
Re: [Qemu-devel] [PATCH 0/5] target-arm: ARM64: Adding EL1 AARCH32 guest support, Sergey Fedorov, 2015/01/20