Re: [Qemu-devel] [PATCH 1/7] isa: add memory space parameter to isa_bus_new

[Paolo Bonzini]

On 19/01/2015 22:28, Hervé Poussineau wrote:
> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
> index f0a3201..8f932c9 100644
> --- a/hw/i386/pc_piix.c
> +++ b/hw/i386/pc_piix.c
> @@ -208,7 +208,7 @@ static void pc_init1(MachineState *machine,
>      } else {
>          pci_bus = NULL;
>          i440fx_state = NULL;
> -        isa_bus = isa_bus_new(NULL, system_io);
> +        isa_bus = isa_bus_new(NULL, get_system_memory(), system_io);
>          no_hpet = 1;
>      }
>      isa_bus_irqs(isa_bus, gsi);

I suspect the right thing to do would be the PCI address space, since
the ISA bridge on real hardware has BusMaster+ set in lspci.  But if
firmware doesn't set it for virtual machines, passing
get_system_memory() is probably a good idea.

Reviewed-by: Paolo Bonzini <address@hidden>