qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header


From: Stefan Hajnoczi
Subject: Re: [Qemu-devel] [PATCH RFC v6 16/20] virtio-net: support longer header
Date: Tue, 20 Jan 2015 13:18:14 +0000
User-agent: Mutt/1.5.23 (2014-03-12)

On Thu, Dec 11, 2014 at 02:25:18PM +0100, Cornelia Huck wrote:
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index ebbea60..7ee2bd6 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -373,15 +373,21 @@ static int peer_has_ufo(VirtIONet *n)
>      return n->has_ufo;
>  }
>  
> -static void virtio_net_set_mrg_rx_bufs(VirtIONet *n, int mergeable_rx_bufs)
> +static void virtio_net_set_mrg_rx_bufs(VirtIONet *n, int mergeable_rx_bufs,
> +                                       int version_1)

Please use bool, it makes it 100% clear what the meaning of "version_1"
is.

s/int/bool/

Attachment: pgp6hQ8GyUsv1.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]