Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264

[Maciej W. Rozycki]

On Tue, 20 Jan 2015, Markus Armbruster wrote:

> >> diff --git a/target-mips/translate.c b/target-mips/translate.c
> >> index e9d86b2..8abc12b 100644
> >> --- a/target-mips/translate.c
> >> +++ b/target-mips/translate.c
> >> @@ -18729,6 +18729,7 @@ static void decode_opc(CPUMIPSState *env, 
> >> DisasContext *ctx)
> >>      case OPC_SWL:
> >>      case OPC_SWR:
> >>          check_insn_opc_removed(ctx, ISA_MIPS32R6);
> >> +         /* fall through */
> >
> > Indent here seems to be out by one? The others look OK.
> 
> Sorry about that.  Fix up on commit, or would you like a respin?

 It looks to me like this whole file requires reindentation, perhaps a 
mechanical update like that would be better.  There are many lines with 9 
leading spaces (`wc -l' tells me 20), that I deliberately left as they are 
with my recent patches in this area so as not to obfuscate semantic 
changes.  There may be some more issues.

  Maciej