[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Ma
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD |
Date: |
Tue, 20 Jan 2015 21:28:29 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Programmingkid <address@hidden> writes:
> On Jan 20, 2015, at 10:22 AM, Eric Blake wrote:
>
>> On 01/20/2015 07:29 AM, Programmingkid wrote:
>>>
>>> On Jan 20, 2015, at 3:33 AM, Markus Armbruster wrote:
>>>
>>>> Programmingkid <address@hidden> writes:
>>>>
>>>>> Subject was:
>>>>> Re: [PATCH v7] block/raw-posix.c: Fixes raw_getlength()
>>>>> on Mac OS X so that it reports the correct length of a real CD
>>>>
>>>> Patch history information goes...
>>
>>>>
>>>> ... below the --- divider.
>>>
>>> I thought I did this. The information above is the description of the
>>> patch.
>>> Not its history.
>>
>> Anything that mentions 'v7' is history. When you read 'git log', you
>> will not see mentions of 'v7', because no one cares how many tries it
>> took to get a patch into git. Knowing about v7 only matters to the
>> reviewers of v8, hence it is patch history that belongs after the divider.
>
> Ok.
>
>>
>>
>>>>> +
>>>>> + if (ioctl(fd, DKIOCGETBLOCKCOUNT, §ors) == 0
>>>>> + && ioctl(fd, DKIOCGETBLOCKSIZE, §or_size) == 0) {
>>
>> Indentation looks off here.
>
> It does look a little odd, but it also communicates that this is one
> statement (IMHO).
It's not how the rest of QEMU is indented. Please try to blend in :)
I feel bad about notpicking v8 of an obviously useful and patch that is
basically just fine except for these little things. Thanks for
persevering!
- [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Programmingkid, 2015/01/19
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Markus Armbruster, 2015/01/20
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Programmingkid, 2015/01/20
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Eric Blake, 2015/01/20
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Programmingkid, 2015/01/20
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD,
Markus Armbruster <=
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Programmingkid, 2015/01/20
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Markus Armbruster, 2015/01/21
- Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Programmingkid, 2015/01/21
Re: [Qemu-devel] [PATCH v8] block/raw-posix.c: Fix raw_getlength() on Mac OS X for CD, Stefan Hajnoczi, 2015/01/20