[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vri
|
From: |
David Gibson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] dataplane: move vring_more_avail() into vring.c |
|
Date: |
Wed, 21 Jan 2015 10:56:40 +1100 |
|
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Jan 19, 2015 at 05:04:36PM +0000, Stefan Hajnoczi wrote:
> vring_more_avail() was an inline function in vring.h. No external
> callers use it so it's not necessary to export it.
>
> Furthermore, we'll need virtio-access.h for endian-aware memory accesses
> but that only works in per-target object files (obj-y) and not
> build-once object files (common-obj-y) like the virtio-blk and
> virtio-scsi devices.
>
> Move vring_more_avail() into vring.c so that virtio devices like
> virtio-blk and virtio-scsi can continue to use vring.h without being
> built once per target.
>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
Looks sensible to me.
Reviewed-by: David Gibson <address@hidden>
Tested-by: David Gibson <address@hidden>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
pgp7nG86Sgv0m.pgp
Description: PGP signature