Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge

[Chen, Tiejun]

> > +
> > +    if (pch_dev_id == 0xffff) {
> > +        fprintf(stderr, "unsupported PCH!\n");
>
> I would drop this fprintf: this likely means a newer
> card, so the bridge is not necessary.

Okay.

> > +        return;
> > +    }
> > +
> > +    /* Currently IGD drivers always need to access PCH by 1f.0. */
> > +    pci_dev = pci_create_simple(d->bus, PCI_DEVFN(0x1f, 0),
> > +                                "xen-igd-passthrough-isa-bridge");
> > +
> > +    /*
> > +     * Identify PCH card with its own real vendor/device ids.
>
> This no longer holds I think.

You're right.

Thanks
Tiejun