Re: [Qemu-devel] [v6][PATCH 07/10] xen, gfx passthrough: register a isa bridge

[Chen, Tiejun]

> > +static void
> > +xen_igd_passthrough_isa_bridge_create(XenPCIPassthroughState *s,
> > +                                      XenHostPCIDevice *dev)
> > +{
>
> I suggest this implementation, and the table, are moved
> to the same file where igd-passthrough-isa-bridge
> is implemented. The function can get PCIDevice *d, this way
> it's not xen specific.

Absolutely, you're right.

Actually I already start to work this way since Gerd said this should 
have a common between Xen and Kvm(KvmGT).

> > +    struct PCIDevice *pci_dev;
>
> pls rename bridge_dev;

Okay.

Thanks
Tiejun