[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time'
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] qemu-ga-win: Fail loudly on bare 'set-time' |
|
Date: |
Wed, 21 Jan 2015 16:25:52 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
On 01/21/2015 04:09 AM, Michal Privoznik wrote:
> The command is not implemented correctly yet. The documentation allows
> to not pass any value to set, in which case the time is re-read from
> RTC. However, reading CMOS on Windows is not trivial to implement. So
> instead of pretending we've set the correct time, fail explicitly.
>
> Signed-off-by: Michal Privoznik <address@hidden>
> ---
> qga/commands-win32.c | 44 ++++++++++++++++++++++----------------------
> qga/qapi-schema.json | 5 ++++-
> 2 files changed, 26 insertions(+), 23 deletions(-)
Harder to read because of indentation change, but fairly simple. I'm
okay with the code change, but I'll leave it to someone more familiar
with Windows on whether this is the right technical decision.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature