qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] hw/input/hid.c Fix capslock hid code


From: Dinar Valeev
Subject: Re: [Qemu-devel] [PATCH] hw/input/hid.c Fix capslock hid code
Date: Thu, 22 Jan 2015 08:59:23 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0



On 01/22/2015 08:20 AM, Gerd Hoffmann wrote:
On Mi, 2015-01-21 at 23:48 +0100, address@hidden wrote:
From: Dinar Valeev <address@hidden>

When ever USB keyboard is used, e.g. '-usbdevice keyboard' pressing
caps lock key send 0x32 hid code, which is treated as backslash.
Instead it should be 0x39 code. This affects sending uppercase keys,
as they typed whith caps lock active.

While on x86 this can be workarounded by using ps/2 protocol. On
Power it is crusial as we don't have anything else than USB.

This is fixes guest automation tasts over vnc.

That probably happens because your test automation vnc client sends
uppercase letters without also sending shift-down/up events.  The qemu
vnc server logic which is supposed to sync up capslock state between
guest and host thinks capslock is pressed on the host then and injects
some synthetic capslock key events.

Just say'ing FYI, that doesn't render the fix invalid, but you may have
wondered why you are not seeing this with a normal vnc client ;)
Yeah, I thought about sending shift+letter. It become better, but not really. Sending shift-b would print "|B".

I've seen this behaviour with a home grown perl vnc client, ruby-vnc as well as with manual vncviewer client, vnc and SDL ui.

The reproducer is simple: qemu-system-x86_64 -enable-kvm -cdrom SLE-12-Server-MINI-ISO-x86_64-GM-DVD.iso -usbdevice keyboard -m 1024

Pressing caps lock produces "\". showkey says backslash is pressed.

Dinar,

Added to input queue.
Thanks

thanks,
   Gerd





reply via email to

[Prev in Thread] Current Thread [Next in Thread]