qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints


From: Pavel Dovgaluk
Subject: Re: [Qemu-devel] [RFC PATCH v7 15/21] replay: checkpoints
Date: Thu, 22 Jan 2015 11:50:22 +0300

> From: Paolo Bonzini [mailto:address@hidden
> On 13/01/2015 10:15, Pavel Dovgaluk wrote:
> > The numbers have no meaning. They just have to be distinct in different 
> > places.
> 
> This is easier to achieve if you give a name to each place.
> 
> > Sorry, missed one thing.
> > run_all is used to distinguish timers processed in AIO by calling of
> timerlistgroup_run_timers function
> > and in main loop by calling qemu_clock_run_all_timers.
> 
> Should you instead distinguish which TimerListGroup is being run?  Then
> main loop would checkpoint once for every TimerListGroup (which means
> twice).

I checked that. We should distinguish only run_all_timers and all other calls.
Distinguishing the TimerListGroups does not work - replay hangs.

Pavel Dovgalyuk




reply via email to

[Prev in Thread] Current Thread [Next in Thread]