Re: [Qemu-devel] [PATCH] sb16: fix interrupt acknowledgement

[Gerd Hoffmann]

On Di, 2015-01-20 at 17:23 +0100, Paolo Bonzini wrote:
> SoundBlaster 16 emulation is very broken and consumes a lot of CPU, but a
> small fix was suggested offlist and it is enough to fix some games.  I
> got Epic Pinball to work with the "SoundBlaster Clone" option.
> 
> The processing of the interrupt register is wrong due to two missing
> "not"s.  This causes the interrupt flag to remain set even after the
> Acknowledge ports have been read (0x0e and 0x0f).
> 
> The line was introduced by commit 85571bc (audio merge (malc), 2004-11-07),
> but the code might have been broken before because I did not look closely
> at the huge patches from 10 years ago.

Looks sane, picked up.

thanks,
  Gerd