Re: [Qemu-devel] [PATCH v2 4/4] linux-user: initialize progname with error_set_progname()

[Peter Maydell]

On 22 January 2015 at 09:08, Hitoshi Mitake
<address@hidden> wrote:
> Calling error_get_progname() in the context of qemu-x86_64 can cause
> segmentation fault because linux-user/main.c doesn't initialize its
> progname with error_set_progname(). This patch adds the
> initialization.
>
> Currently, the missing call of error_set_progname() doesn't cause any
> problems because qemu-x86_64 doesn't use error_get_progname(). This
> patch is a proactive action.

I don't think this patch is right. The *-user binaries don't
(and should not) use the qemu-error infrastructure (they don't
have the monitor or any of the other stuff that uses). Code
which tries to use error_get_progname() in *-user would be
broken.

thanks
-- PMM