[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 4/6] block: remove unused variable in bdrv_commit
From: |
Jeff Cody |
Subject: |
[Qemu-devel] [PATCH v3 4/6] block: remove unused variable in bdrv_commit |
Date: |
Thu, 22 Jan 2015 08:03:28 -0500 |
As Stefan pointed out, the variable 'filename' in bdrv_commit is unused,
despite being maintained in previous patches.
With this patch, get rid of the variable for good.
Signed-off-by: Jeff Cody <address@hidden>
---
block.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/block.c b/block.c
index cbe4a32..d45e4dd 100644
--- a/block.c
+++ b/block.c
@@ -2207,7 +2207,6 @@ int bdrv_commit(BlockDriverState *bs)
int n, ro, open_flags;
int ret = 0;
uint8_t *buf = NULL;
- char filename[PATH_MAX];
if (!drv)
return -ENOMEDIUM;
@@ -2222,8 +2221,6 @@ int bdrv_commit(BlockDriverState *bs)
}
ro = bs->backing_hd->read_only;
- /* Use pstrcpy (not strncpy): filename must be NUL-terminated. */
- pstrcpy(filename, sizeof(filename), bs->backing_hd->filename);
open_flags = bs->backing_hd->open_flags;
if (ro) {
--
1.9.3
- [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 1/6] block: vmdk - make ret variable usage clear, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 2/6] block: vmdk - move string allocations from stack to the heap, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 3/6] block: qapi - move string allocation from stack to the heap, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 5/6] block: mirror - change string allocation to 2-bytes, Jeff Cody, 2015/01/22
- [Qemu-devel] [PATCH v3 4/6] block: remove unused variable in bdrv_commit,
Jeff Cody <=
- [Qemu-devel] [PATCH v3 6/6] block: update string sizes for filename, backing_file, exact_filename, Jeff Cody, 2015/01/22
- Re: [Qemu-devel] [PATCH v3 0/6] Update filename string sizes in block layer, Kevin Wolf, 2015/01/23