[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using
From: |
Chen Gang S |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base |
Date: |
Fri, 23 Jan 2015 18:57:28 +0800 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 |
Thank you for all of your work.
I plan to let qemu support tile architecture: "can let gcc run testsuite
with qemu for tile". It is really hard to me, but I should try, it is my
duty (I met it, and it's within my boarder, although no one pay for me).
:-)
At present, I am just preparing:
- Reading architecture related documents (thank tile kernel member, who
let me know about all tile architecture related documents).
- Reading qemu architecture related code for understanding how to add
tile code for qemu.
- After preparing, I should provide a schedule for it (the steps, and
the time point, and the risks which I may face to). Hope I can finish
preparing within this month.
Welcome any ideas, suggestions and completions by any members, e.g.
- Share any related documents or knowledge for architecture.
- Is there any original code for tile? Maybe originally, someone tried
qemu for tile, but the related code was not merged into main line.
- Suggestions about the schedule: the common steps, the time resources
may need, and which risks have to face to.
Thanks.
On 1/23/15 18:08, Peter Maydell wrote:
> On 23 January 2015 at 10:07, Chen Gang S <address@hidden> wrote:
>> It is only a typo issue, need use tswapal(target_vec[i].iov_len) for the
>> len.
>>
>> Signed-off-by: Chen Gang <address@hidden>
>> ---
>> linux-user/syscall.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index a66c2ae..8260ed7 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -1896,7 +1896,7 @@ static void unlock_iovec(struct iovec *vec, abi_ulong
>> target_addr,
>> if (target_vec) {
>> for (i = 0; i < count; i++) {
>> abi_ulong base = tswapal(target_vec[i].iov_base);
>> - abi_long len = tswapal(target_vec[i].iov_base);
>> + abi_long len = tswapal(target_vec[i].iov_len);
>> if (len < 0) {
>> break;
>> }
>> --
>> 1.9.3 (Apple Git-50)
>
> Nice catch.
> Reviewed-by: Peter Maydell <address@hidden>
>
> thanks
> -- PMM
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix typo issue for using target_vec[i].iov_len instead of target_vec[i].iov_base, Michael Tokarev, 2015/01/27