Re: [Qemu-devel] [PATCH 2/4] target-arm: Add extended RVBAR support

[Peter Maydell]

On 23 January 2015 at 14:49, Greg Bellows <address@hidden> wrote:
> Added RVBAR_EL2 and RVBAR_EL3 CP register support.  All RVBAR_EL# registers
> point to the same location and only the highest EL version exists at any one
> time.
>
> Signed-off-by: Greg Bellows <address@hidden>

>      if (arm_feature(env, ARM_FEATURE_EL2)) {
>          define_arm_cp_regs(cpu, v8_el2_cp_reginfo);
> +        /* RVBAR_EL2 is only implemented if EL2 is the highest EL */
> +        if (!arm_feature(env, ARM_FEATURE_EL3)) {
> +            ARMCPRegInfo rvbar = {
> +                .name = "RVBAR_EL3", .state = ARM_CP_STATE_AA64,

Should be "RVBAR_EL2"...

> +                .opc0 = 3, .opc1 = 4, .crn = 12, .crm = 0, .opc2 = 1,
> +                .type = ARM_CP_CONST, .access = PL2_R, .resetvalue = 
> cpu->rvbar
> +            };
> +            define_one_arm_cp_reg(cpu, &rvbar);
> +        }

Otherwise
Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM