Re: [Qemu-devel] [Spice-devel] [PATCH] [RFC] LZ4 compression option for SPICE

[Javier Celaya]

Sorry, I forgot to patch the command-line help. Hope it helps.

El Viernes, 23 de enero de 2015 09:25:38 Eric Blake escribió:
> On 01/23/2015 07:06 AM, Javier Celaya wrote:
> > Hello, this is the patch with the version check. Christophe, can you check
> > that the version is the correct one?
> > 
> > 
> > 
> > Recently, SPICE included the lz4 compression algorithm. This patch adds
> > a command line option to select it.
> > ---
> > 
> >  ui/spice-core.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/ui/spice-core.c b/ui/spice-core.c
> > index 6467fa4..dadcae9 100644
> > --- a/ui/spice-core.c
> > +++ b/ui/spice-core.c
> > @@ -359,6 +359,9 @@ static const char *compression_names[] = {
> > 
> >      [ SPICE_IMAGE_COMPRESS_QUIC ]     = "quic",
> >      [ SPICE_IMAGE_COMPRESS_GLZ ]      = "glz",
> >      [ SPICE_IMAGE_COMPRESS_LZ ]       = "lz",
> > 
> > +#if SPICE_SERVER_VERSION >= 0x000c07
> > +    [ SPICE_IMAGE_COMPRESS_LZ4 ]      = "lz4",
> 
> How is libvirt going to introspect whether the command line supports
> this option?  Is there some QMP command that lists the set of valid
> compression formats understood by a given qemu binary?

0001-Add-lz4-compression-option-for-SPICE.patch
Description: Text Data